Automate dependency update merges - #153
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| - name: Install prek | ||
| if: steps.dependency.outputs.ecosystem == 'github-actions' | ||
| uses: taiki-e/install-action@v2 |
There was a problem hiding this comment.
Mutable installer controls merge validation
If the upstream taiki-e/install-action@v2 tag is retargeted, the verification job executes unreviewed installer code and uses its installed prek binary to determine success, allowing an unsafe GitHub Actions dependency update to be approved for auto-merge. How this was verified: The mutable installer supplies the executable used by the checks whose success starts the write-capable auto-merge job.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/dependabot-auto-merge.yml
Line: 97
Comment:
**Mutable installer controls merge validation**
If the upstream `taiki-e/install-action@v2` tag is retargeted, the verification job executes unreviewed installer code and uses its installed `prek` binary to determine success, allowing an unsafe GitHub Actions dependency update to be approved for auto-merge. **How this was verified:** The mutable installer supplies the executable used by the checks whose success starts the write-capable auto-merge job.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Adds guarded auto-merge workflows for prek hook updates plus npm and GitHub Actions Dependabot pull requests, with weekly checks and a seven-day cooldown for version updates.
What Changed
cooldown.default-days: 7for both ecosystems.Why
This reduces routine dependency maintenance while ensuring only narrowly scoped, bot-authored updates can be merged automatically after ecosystem-appropriate validation succeeds.
Before Merge
PREK_AUTOUPDATE_TOKENfor the prek update workflow.Greptile Summary
This PR adds guarded auto-merge automation for Dependabot and prek-generated updates, alongside weekly dependency update configuration.
Confidence Score: 2/5
The PR is not yet safe to merge because dependency updates can bypass the intended validation and a mutable third-party action still receives a write-capable repository secret.
Dependabot auto-merge now proceeds after filename authorization without YAML/actionlint validation, and the prek update workflow continues to expose PREK_AUTOUPDATE_TOKEN to Snuffy2/prek-autoupdate@v2 rather than a reviewed immutable commit.
Files Needing Attention: .github/workflows/dependabot-auto-merge.yml and .github/workflows/prek_autoupdate.yml
Important Files Changed
Prompt To Fix All With AI
Reviews (3): Last reviewed commit: "Avoid duplicate Dependabot validation" | Re-trigger Greptile