Expose vehicle caravan action boundaries - #359
Open
sviyh wants to merge 1 commit into
Open
Conversation
Route vehicle selection through the vanilla completion transaction while substituting the vehicle-specific exit tile, and expose the final send action so Multiplayer compatibility can register the intended boundary directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dialog_FormCaravan.Notify_ChoseRoutewhile substituting the vehicle-specific exit tile.Root cause
Vehicle Framework completed route selection in a custom callback that duplicated part of vanilla's state, estimate, sound, and automatic-supply transaction. Its final send action was also a local function. Multiplayer compatibility therefore had to target lower-level implementation details, and the copied route flow could drift from vanilla behavior.
Approach
The vehicle route planner now returns through vanilla
Notify_ChoseRoute. A narrow transpiler replaces only vanilla's exit-tile calculation, selectingCaravanHelper.BestExitTileToGoTowhen vehicles are present and retaining the vanilla fallback otherwise. The existing final send body is lifted unchanged intoCaravanFormation.TryFormAndSendCaravan.Test plan