fix: make vehicles able to engage and roadkill all hostile pawns including manhunter animals - #354
Merged
Conversation
previously vehicles weren't dealing hit damage to manhunting animals because they lacked faction Assisted-by: pi:gpt-5.6-sol Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
scarf005
force-pushed
the
fix/manhunter-roadkill
branch
from
August 2, 2026 11:11
3315c83 to
e63b4ee
Compare
Assisted-by: pi:gpt-5.6-sol Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
scarf005
force-pushed
the
fix/manhunter-roadkill
branch
from
August 2, 2026 11:13
e63b4ee to
e57b4d9
Compare
Owner
|
I appreciate the AI disclosure. Sorry it took so long for me to get to this @scarf005 The only remark I have is that this may be a bit redundant. I think the same can be accomplished by just switching the check from I'll make the changes after merging since you've probably moved on already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specifically, both weren't happening because hostility check wasn't checking
enemy pawn is hostile to vehicle but vice-versa isn'tkindTesting
Before
_1.785.655.778.157.mp4
After
_after.mp4
Extra
AI usage disclosure: used AI for writing commits (gpt 5.6 sol on pi). Everything else, including testing and opening this PR was done manually.