Skip to content

remove manual link and change content #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cofaulco wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove manual link and change content #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cbc979
remove manual link and change content
cofaulco Jul 17, 2025
a4ff5c3
fix unit test
cofaulco Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ....DAS.ProviderCommitments.Web.UnitTests/Models/Cohort/SelectLearnerRecordViewModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void PageTitleIsCorrect(string employerName)
{
_viewModel.EmployerAccountName = employerName;
//Assert
_viewModel.PageTitle.Should().EndWith(employerName);
_viewModel.PageTitle.Should().Be("Select learner from ILR");
}

[TestCase(true, "das-table__sort--desc")]
Expand Down
2 changes: 1 addition & 1 deletion ...Commitments/SFA.DAS.ProviderCommitments.Web/Models/Cohort/SelectLearnerRecordViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class SelectLearnerRecordViewModel : IAuthorizationContextModel
public Guid? ReservationId { get; set; }

public List<LearnerSummary> Learners { get; set; } = new();
public string PageTitle => $"Select apprentices from ILR for {EmployerAccountName}";
public string PageTitle => "Select learner from ILR";

public string SortedByHeaderClassName { get; set; }
public const string HeaderClassName = "das-table__sort";
Expand Down
32 changes: 13 additions & 19 deletions ...viderCommitments/SFA.DAS.ProviderCommitments.Web/Views/Learner/SelectLearnerRecord.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,21 @@
<h1 class="govuk-heading-xl">@Model.PageTitle</h1>

<p class="govuk-body">
If you cannot find the apprentice you're looking for, try:
These are the learners you've submitted an ILR for that are linked to <strong>@Model.EmployerAccountName</strong>. It also includes any learners who are not linked to an employer in the ILR.
</p>

<ul class="govuk-list govuk-list--bullet xgovuk-list--spaced">
<li>refreshing this page</li>
<li>updating the ILR</li>
<li>
@if (!string.IsNullOrWhiteSpace(Model.CohortReference))
{
<a href="@Url.Action("AddDraftApprenticeshipCourse", "DraftApprenticeship", new {Model.ProviderId, Model.CohortReference, Model.ReservationId, Model.CacheKey})" class="govuk-link">
manually adding your apprentice
</a>
}
else
{
<a href="@Url.Action("SelectCourse", "Cohort", new {Model.ProviderId, Model.CacheKey, Model.ReservationId})" class="govuk-link">
manually adding your apprentice
</a>
}
</li>
</ul>
<details class="govuk-details" data-module="govuk-details">
<summary class="govuk-details__summary">
<span class="govuk-details__summary-text">
I can't find the learner I need
</span>
</summary>
<div class="govuk-details__text">
<p class="govuk-body">
It can take up to 15 minutes for these records to update after an ILR file is submitted. Try refreshing this page after 15 minutes.
</p>
</div>
</details>
</div>
</div>

Expand Down
Loading