Skip to content

remove manual option - #713

Open
cofaulco wants to merge 6 commits into
masterfrom
APPMAN-1634_remove-manual-option
Open

remove manual option#713
cofaulco wants to merge 6 commits into
masterfrom
APPMAN-1634_remove-manual-option

Conversation

@cofaulco

Copy link
Copy Markdown
Contributor

No description provided.

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@Pauljgraham Pauljgraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This partly works, but because of the parameter UseLearnerData=True which is passed down from page to page. The end user can remove this flag on the routes and hence add apprentices manually.

Also there is a potential some of the back link will accidently remove this URL param and hence we will be back to adding apprenticeship manually

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@das-github-app

Copy link
Copy Markdown

🔒 Please remember to check any packages used by this application to ensure they are up to date @cofaulco. cc/ @ecarroll95

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants