UKPRN Nullable format validator - #35
Open
shaun-downey-education wants to merge 1 commit into
Open
Conversation
shaun-downey-education
commented
Jul 1, 2024
shaun-downey-education
commented
Contributor
- Added an additional nullable Ukrpn validator as a placeholder to replace the existing once changed to non nullable.
|
DevenKShah
reviewed
Jul 1, 2024
| .When(model => model.Ukprn.HasValue); | ||
| } | ||
|
|
||
| public static IRuleBuilderOptions<T, long?> CheckNullableUkprnFormat<T>(this IRuleBuilder<T, long?> ruleBuilder) where T : INullableUkprnEntity |
Contributor
There was a problem hiding this comment.
I think this will invalidate in case of null, no? We need a test added for null value resulting in valid request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.