feat: add phase 4 resources - #25
Merged
Merged
Conversation
Merged
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 18, 2026
Merged
Sivivatu
marked this pull request as ready for review
March 18, 2026 17:03
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e31b59a05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds new Alteryx Server V3 resource wrappers (collections, credentials, server) and wires them into the sync/async clients to expand the public API surface of alteryx_server_py.
Changes:
- Introduces
CollectionResource/AsyncCollectionResource,CredentialResource/AsyncCredentialResource, andServerResource/AsyncServerResource. - Exposes the new resources via
AlteryxClient/AsyncAlteryxClientproperties andresources.__init__exports. - Adds
CollectionNotFoundError/CredentialNotFoundErrorand adjusts request headerContent-Typehandling for form/json/multipart requests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/alteryx_server_py/resources/server.py | New server info/settings resource (sync + async). |
| src/alteryx_server_py/resources/credentials.py | New credential CRUD resource (sync + async) + response coercion helper. |
| src/alteryx_server_py/resources/collections.py | New collections CRUD/share/permission APIs (sync + async) + response coercion helper. |
| src/alteryx_server_py/resources/init.py | Re-exports newly added resources. |
| src/alteryx_server_py/exceptions.py | Adds collection/credential-specific 404 exceptions. |
| src/alteryx_server_py/client.py | Adds .collections/.credentials/.server properties + adjusts Content-Type selection. |
| src/alteryx_server_py/async_client.py | Adds .collections/.credentials/.server properties + adjusts Content-Type selection. |
| src/alteryx_server_py/init.py | Exposes new exceptions at package root. |
Comments suppressed due to low confidence (2)
src/alteryx_server_py/client.py:154
- These debug logs print the full
data/json_datapayload. With the new credential APIs sending passwords viadata, enabling debug logging would leak secrets to logs. Redact sensitive fields (e.g., password/new_password/client_secret) or avoid logging request bodies altogether.
logger.debug(f"{method} {url}")
logger.debug(f"Params: {params}")
logger.debug(f"Data: {data}")
logger.debug(f"JSON: {json_data}")
src/alteryx_server_py/async_client.py:145
- These debug logs print the full
data/json_datapayload. With the new credential APIs sending passwords viadata, enabling debug logging would leak secrets to logs. Redact sensitive fields (e.g., password/new_password/client_secret) or avoid logging request bodies altogether.
logger.debug(f"ASYNC {method} {url}")
logger.debug(f"Params: {params}")
logger.debug(f"Data: {data}")
logger.debug(f"JSON: {json_data}")
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughRemoves ChangesCredential API reduction, collection encoding fix, and logging hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
Owner
Author
Merge activity
|
Sivivatu
changed the base branch from
03-18-feat_add_phase_4_models
to
graphite-base/25
May 8, 2026 11:01
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
from
June 19, 2026 20:51
bb45e8a to
008081f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 008081f227
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 008081f227
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sivivatu
force-pushed
the
graphite-base/25
branch
from
June 22, 2026 08:39
c7feb52 to
b779d88
Compare
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
from
June 22, 2026 08:39
008081f to
3b2450f
Compare
Sivivatu
force-pushed
the
graphite-base/25
branch
from
June 22, 2026 08:43
b779d88 to
b1c36cc
Compare
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
2 times, most recently
from
June 22, 2026 08:48
5739c59 to
1a80fef
Compare
Sivivatu
force-pushed
the
graphite-base/25
branch
from
June 22, 2026 08:48
b1c36cc to
10f5c97
Compare
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
from
June 22, 2026 08:52
1a80fef to
68cbece
Compare
Sivivatu
force-pushed
the
graphite-base/25
branch
from
June 22, 2026 08:52
10f5c97 to
41abc4f
Compare
Code Review SummaryStatus: No New Issues Found | Recommendation: Merge This incremental review confirms all changes address previous findings:
Overview
Files Reviewed (10 files)
Previous Review Summaries (2 snapshots, latest commit 7f0e811)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7f0e811)Status: No New Issues Found | Recommendation: Merge This incremental review confirms all changes address previous findings:
Overview
Files Reviewed (10 files)
Previous review (commit 68cbece)Status: No New Issues Found | Recommendation: Merge All introduced code changes have been verified against the existing review comments. Overview
Existing Open Issues (from prior reviews, not duplicated)
Files Reviewed (10 files)
Reviewed by laguna-m.1-20260312:free · Input: 245.6K · Output: 3.3K · Cached: 83.9K |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sivivatu
changed the base branch from
graphite-base/25
to
03-18-feat_add_phase_4_models
June 22, 2026 08:59
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_models
branch
from
June 22, 2026 09:09
41abc4f to
a295dd4
Compare
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
from
June 22, 2026 09:09
68cbece to
7f0e811
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sivivatu
force-pushed
the
03-18-feat_add_phase_4_resources
branch
from
June 23, 2026 11:15
7f0e811 to
9f9034e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit