-
Notifications
You must be signed in to change notification settings - Fork 0
removed comment section #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3142b30
58bf973
e0e4d2f
3c50582
2451c4f
b1dfdb3
02ba213
3314250
a5e595d
0257d86
fd80d40
87a703c
9075499
b0c592b
8d23680
a72024f
8bd07f9
4552921
bbefe35
a84469a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -30,13 +30,12 @@ dependencies = [ | |||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| [project.optional-dependencies] | ||||||||||||||||||||||||||||||||||||
| dev = [ | ||||||||||||||||||||||||||||||||||||
| "hatch-vcs>=0.4.0", | ||||||||||||||||||||||||||||||||||||
| "hatch>=1.13.0", | ||||||||||||||||||||||||||||||||||||
| "pytest>=8.3.3", | ||||||||||||||||||||||||||||||||||||
| "pytest-cov>=6.0.0", | ||||||||||||||||||||||||||||||||||||
| "pytest-asyncio>=0.24.0", | ||||||||||||||||||||||||||||||||||||
| "respx>=0.22.0", | ||||||||||||||||||||||||||||||||||||
| "ruff>=0.8.0", | ||||||||||||||||||||||||||||||||||||
| "pytest-cov>=6.0.0", | ||||||||||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||||||||||
|
Comment on lines
32
to
39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate
Proposed fix dev = [
"pytest>=8.3.3",
"pytest-cov>=6.0.0",
"pytest-asyncio>=0.24.0",
"respx>=0.22.0",
"ruff>=0.8.0",
- "pytest-cov>=6.0.0",
]📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| [project.urls] | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -368,6 +368,20 @@ | |||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| ## Discovered During Work | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| - [x] **Fix failing test suite** (2026-03-17) | ||||||||||||||||||||||||||||
| - Fixed 4 test files still importing from old `alteryx_gallery_api` package (renamed to `alteryx_server_py`) | ||||||||||||||||||||||||||||
| - Fixed `test_exceptions.py` infinite recursion caused by Windows path separator mismatch in `importlib.util.spec_from_file_location` | ||||||||||||||||||||||||||||
| - Fixed `test_workflows.py` calling non-existent `get_workflows()` method (now uses `client.workflows.list()`) | ||||||||||||||||||||||||||||
| - Fixed `test_job_resource.py` async/sync mismatch (used sync client with `await`) and broken `respx` mock patterns | ||||||||||||||||||||||||||||
| - Fixed `test_client.py` and `test_client_get_workflows_models.py` using `responses` library (migrated to `respx`/`unittest.mock`) | ||||||||||||||||||||||||||||
| - Fixed test data using invalid `ExecutionMode` enum value (`"Standard"` → `"Safe"`) | ||||||||||||||||||||||||||||
| - Fixed duplicate empty `class AlteryxClient` definition in `client.py` causing `IndentationError` | ||||||||||||||||||||||||||||
| - Fixed `AsyncJobResource.cancel()` string-based error detection to use explicit `NotFoundError` type catching | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||
|
Comment on lines
+371
to
+383
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate "Discovered During Work" section. This section duplicates the heading at line 264 and the "Fix failing test suite" entry already present at lines 340-348. The static analysis tool also flags this as a duplicate heading (MD024). Proposed fix-## Discovered During Work
-
-- [x] **Fix failing test suite** (2026-03-17)
- - Fixed 4 test files still importing from old `alteryx_gallery_api` package (renamed to `alteryx_server_py`)
- - Fixed `test_exceptions.py` infinite recursion caused by Windows path separator mismatch in `importlib.util.spec_from_file_location`
- - Fixed `test_workflows.py` calling non-existent `get_workflows()` method (now uses `client.workflows.list()`)
- - Fixed `test_job_resource.py` async/sync mismatch (used sync client with `await`) and broken `respx` mock patterns
- - Fixed `test_client.py` and `test_client_get_workflows_models.py` using `responses` library (migrated to `respx`/`unittest.mock`)
- - Fixed test data using invalid `ExecutionMode` enum value (`"Standard"` → `"Safe"`)
- - Fixed duplicate empty `class AlteryxClient` definition in `client.py` causing `IndentationError`
- - Fixed `AsyncJobResource.cancel()` string-based error detection to use explicit `NotFoundError` type catching
-
----
-📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.22.1)[warning] 371-371: Multiple headings with the same content (MD024, no-duplicate-heading) 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| ## Next Steps | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| 1. Add Google-style docstrings to the remaining public APIs | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.