Add adaptive card artwork display - #29
Open
Sisyphe42 wants to merge 5 commits into
Open
Conversation
Define validated per-asset fit and focal metadata, expose matching local and Hosted editor mutations, and preserve display settings across image replacement. Review the nested metadata merge and host-parity API coverage.
Render card artwork through a shared defensive runtime across Creator, Hosted, and standalone Players, with fit and focal-point controls plus packaged runtime coverage. Review the fixed 1:1 frame semantics, accessibility behavior, and offline build inclusion.
Document the asset display schema, persistence contract, rendering modes, and packaging requirement. Add Hosted coverage for Creator Preview plus landscape, portrait, and square source images. Review the recorded validation results and compatibility defaults; source images remain unchanged and no image-processing dependency is introduced.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adaptive,contain, andcovermodes plus normalized focal pointsPATCH /api/editor/assets/:assetIdpersistenceContract and compatibility
{ "metadata": { "display": { "fit": "adaptive", "focalPoint": { "x": 0.5, "y": 0.5 } } } }fitacceptsadaptive | contain | cover; focal coordinates must be finite values in0..1adaptivemetadata.display, preserving MIME, SHA, source, and other metadataRendering and smoke evidence
containforeground over anaria-hiddenblurredcoverbackdropcontainforeground without the backdropcoverforeground without the backdropcontain, the backdrop wasaria-hidden, and no page errors occurredValidation
npm run verify— passed (112 unit tests, 30 integration tests)npm run test:hosted— passed (19 browser tests)npm run build:game -- fixtures/content/oss-court.cards.json <temporary-output-dir>— passed; emittedassets/card-artwork.jsand all referenced assetsNo Sharp, smartcrop.js, cropper, or other image-processing dependency was added. The implementation creates no derived images and does not modify source asset bytes, dimensions, formats, or URIs.