fix: correct Fabric overlay text orientation - #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorldRenderEvents.LASTRoot cause
Fabric 1.21 moved the overlay hook from the late world-render event to
AFTER_ENTITIES. That event is intended for appending to entity consumers and does not establish the camera-view state used by this renderer, causing its explicit billboard rotation to produce upside-down text.The earlier Tweakium 1.4.9 upgrade also retained CC:Tweaked 1.113.0 even though Tweakium requires 1.113.1 or newer.
Verification
./gradlew :fabric:compileKotlin --no-daemon -Pkotlin.incremental=false./gradlew build --no-daemon -Pkotlin.incremental=falsetimeout --foreground 20m xvfb-run -a ./gradlew gameTest --no-daemon -PminimalTestEnvironment -Pkotlin.incremental=false