Add getPositionRemote, addPeripheral APIs and fix direction handling after reload - #66
Open
vladaliii wants to merge 1 commit into
Open
Add getPositionRemote, addPeripheral APIs and fix direction handling after reload#66vladaliii wants to merge 1 commit into
vladaliii wants to merge 1 commit into
Conversation
Author
|
I am sorry for my description format. I forgot to close the code block : ( |
Owner
|
Hey, I am sorry for such long review, I will merge it, but I will move it to upgraded version of peripheral proxy for gameplay reasons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing with this mod, I felt that as a mod designed to enhance the CC:T experience, it could potentially offer a higher degree of automation efficiency by making the peripheral binding process fully self-contained within CC:T. Since binding a peripheral is already cost-free, I believe this does not affect the mod's balance.
Overview
This PR introduces two new Lua APIs for the Peripheral Proxy (
getPositionRemoteandaddPeripheral) and fixes a bug where bound peripherals would always connect from the north after a world reload.Changes
1. New API:
getPositionRemote(name)Location:
PeripheralProxyPeripheral.kt([line 25]Allows querying the position and facing direction of a remote peripheral by its assigned name.
Usage: