Repository navigation
Fix Stonecutter migration build and publication contracts - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the concrete regressions found while reviewing the Stonecutter migration against the original 1.20 and 1.21 branches.
Verification
./gradlew :spotlessApply cleanTest build generatePomFileForMavenPublication generateMetadataFileForMavenPublication ... --no-daemon: successful. All existing JUnit test tasks with sources executed afresh; 1,596 tests, zero failures/errors/skips across 77 XML reports.python3 scripts/check-publications.py: all 24 publications passed dependency, capability, source archive, artifact, loader metadata, and JVM-target checks.[2.0.1,); normal versions were restored and the final build rerun.git diff --check: passed.Deliberately deferred
The broader one-tree conversion, physical Forge/NeoForge branch split, replacement of the existing reflective buildenv configuration, and wholesale conversion of version snapshots to conditional shared sources are not part of this repair. Existing Gradle paths and publication identities are preserved; no gameplay feature redesign or dependency-version upgrade is included.