Repository navigation
chore: update vulnerable client build dependencies - #30
Merged
Merged
Conversation
npm audit fix, without --force, bumps four transitive packages used only by the client build and the local dev server: - fast-uri 3.1.5 -> 3.1.8 (high; via webpack's schema validation) - qs 6.15.3 -> 6.16.0 - express 4.22.2 -> 4.22.3 - body-parser 1.20.6 -> 1.20.8 (via webpack-dev-server) The built admin bundle is byte-identical. The seven remaining moderate findings are left as they are: uuid only reaches the local dev server through sockjs, which calls v4() without a buffer, so the advisory does not apply; and react-router comes from the minimum-version Kentico admin packages, which the bundle does not include because the host admin provides them at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the high-severity
npm auditfinding, and three moderate ones, in the administration client's build tooling. It runsnpm audit fixwithout--force, which bumps four transitive packages:Only
package-lock.jsonchanges;package.jsonis untouched. The lockfile is marked-diffin.gitattributes, so GitHub doesn't render its diff. A package-by-package comparison ofpackagesagainstmainshows exactly the four version changes above and nothing else.None of these reach consumers. The shipped admin module (
Client/dist, about 16 KB) only importsreact,@kentico/xperience-admin-baseand@kentico/xperience-admin-components, which the host's Xperience admin provides at runtime. It contains no code from any audited package, and it is byte-identical after this change.Remaining findings (7 moderate), left as they are
uuid< 11.1.1 (webpack-dev-server → sockjs, localnpm startonly): the advisory coversv3,v5andv6called with a buffer argument. sockjs only callsuuidv4()with no arguments (sockjs/lib/transport.js). Clearing it needs webpack-dev-server 6, a major upgrade that isn't justified for a finding that doesn't apply.react-router6.30.1 (via@kentico/xperience-admin-*30.11.0): these packages are pinned to the minimum supported Xperience version on purpose, so CI builds the client against it. The audit's suggested fix is 31.8.4, which would break that check and wouldn't change what customers run. The bundle doesn't include react-router; the customer's own admin supplies it, and updating Xperience fixes it for them.Test plan
npm audit: 11 findings (1 high, 10 moderate) → 7 moderate.npm run typecheckpasses.npm test: 17/17 pass.npm run buildoutput is byte-identical (same bundle hash).