Fixed issue with nullish values.#4
Open
avahe-kellenberger wants to merge 1 commit into
Open
Conversation
- Added a helper function to log directly into the terminal (instead of the browser console).
Contributor
Author
|
@JonnyHaystack Do you have idea idea on why this wouldn't be working? |
|
Any update on this being merged? Came across the null value issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue sometimes with values being null or undefined, in the
findValidPortfunction. The main point of the PR is that fix.I've also added a basic
logfunction that will log directly to the terminal/command line, so we could see the logs there instead of the browser's log. If you don't like this change, I can revert it quickly.This doesn't seem to fix #2. I no longer see "Click to reconnect" (it appropriately detects my b0xx), but button presses aren't reflected on the UI.
I am using an R4, and afaik the master branch of HayBox doesn't have r4 support?
I'm currently using my fork for r4 support. It should have the relevant changes needed, but if I'm missing something, please let me know.