Repository navigation
feat(portfolio): complete editorial field notes redesign - #4
Merged
Merged
Conversation
Owner
Author
|
Validation follow-up: the new Static checks GitHub Actions workflow completed successfully on head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progression
Changes
Design and information architecture
detailsandsummary.Content and project presentation
Progressive enhancement and accessibility
innerHTML.Performance and SEO
robots.txt, andsitemap.xml.Validation
scripts/validate_site.pyto check page structure, local links/assets, alt text, safe external tabs, encoding corruption, placeholder links, and project JSON shape.Impact
Verification
python scripts/validate_site.pypassed for all four pages and project data.node --check js/main.jsandnode --check js/projects.jspassed.Visual Evidence
A browser screenshot could not be captured in this workspace because no browser backend was available. Reviewer focus should include 320px, 375px, 768px, 1024px, and 1440px widths in the branch preview.
Risks and Trade-offs
Reviewer Focus
Follow-ups