Skip to content

english translation (language can be switched) / password retype field#1

Open
NichtJens wants to merge 5 commits into
SimonSimCity:masterfrom
NichtJens:master
Open

english translation (language can be switched) / password retype field#1
NichtJens wants to merge 5 commits into
SimonSimCity:masterfrom
NichtJens:master

Conversation

@NichtJens

Copy link
Copy Markdown

No description provided.

@SimonSimCity

SimonSimCity commented Jul 10, 2016

Copy link
Copy Markdown
Owner

Thank your very much for adding the English translation and adding the field.

As you've also updated some exception-texts, I guess the following would be easier:

  1. Create a directory called lang
  2. Add a setting to config.template.php to set the language (set English there and add a comment so other users know what languages are available)
  3. Add an array to the global space called $lang, where you include the file from the lang folder.

What's your opinion on that? Do you have time at hand to realize this? This would at least also make exceptions translatable and would skip that extra template-folder ...

@NichtJens

NichtJens commented Jul 12, 2016

Copy link
Copy Markdown
Author

Yes! That's exactly what I think should be done...

ATM, I do not have the time to implement it, though. That's why I opted for the simpler solution, when I did it. However, I'd be most interested in having it implemented that way at some point.

I'd guess for now it'll be more useful to have my version merged in, than keeping it out. If either of us, will implement the better solution in the future, it can easily be based on my changes as well. So, no loss in merging, I guess.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants