test(tangle-cli): guard tangle-deploy pipeline-compile compat surface#2
Open
Silin144 wants to merge 1 commit into
Open
test(tangle-cli): guard tangle-deploy pipeline-compile compat surface#2Silin144 wants to merge 1 commit into
Silin144 wants to merge 1 commit into
Conversation
Extend the tangle-deploy import-compat guard to cover the compile driver migrated into OSS: the python_pipeline DSL submodules, schema_validation, and pipeline_compiler (compile_pipeline, CompileResult, and the PipelineCompiler(TangleCliHandler) executor). These are the exact tangle_cli.* symbols the internal `tangle-deploy pipeline compile from-python` command will import once it delegates here. Also guard the ZONE_ROOT_MARKERS seam: OSS ships it empty and it must be a mutable list so a downstream distribution (tangle-deploy) can append its own zone-root marker, mirroring the existing mutable-CI-vars provider-override contract. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSS-side of the tangle-deploy → OSS compile migration (Phase 3). Extends the existing
tangle-deployimport-compat guard (tests/test_tangle_deploy_compat_imports.py) so it locks the surface the internaltangle-deploy pipeline compile from-pythoncommand will consume fromtangle_clionce it delegates here.Stacked on #1 (which adds the compile command /
PipelineCompiler), which is stacked on TangleML#20 (thepython_pipelineDSL).What's guarded
tangle_cli.python_pipeline.*submodules — the exact symbols discovery'stangle_deploy/pipeline_compiler.pyimports (cfg,compiler_context,emit,errors,pipeline,ref,registered,subpipeline,trace,types).tangle_cli.schema_validation—SchemaValidationError,validate_dehydrated_pipeline.tangle_cli.pipeline_compiler—compile_pipeline,CompileResult, and thePipelineCompiler(TangleCliHandler)executor the command delegates to.ZONE_ROOT_MARKERSseam — asserts OSS ships it empty and that it is a mutable list, so a downstream distribution (tangle-deploy) can append its own zone-root marker. Mirrors the existing mutable-CI-vars provider-override contract in the same file.Why this is the migration seam
Discovery's compile driver hardcodes the oasis zone-root marker; the OSS port replaces that with an empty, injectable
ZONE_ROOT_MARKERSlist. This test pins the contract that makes the internal command a thin, seam-augmenting delegate rather than a fork.Testing
uv run pytest tests/test_tangle_deploy_compat_imports.py— 4 passeduv run pytest— 733 passed, 0 regressionsuv lock --checkclean,git diff --checkcleanStacking note
feat/pipeline-compileso the diff is this test only. Retarget toTangleML/tangle-cli:masteronce the base PRs merge.🤖 Generated with Claude Code