fix(fetchium): reflect symbol gets on entity proxy to surface prototype symbols - #23
Merged
Merged
Conversation
…pe symbols Fix entity reactivity across the React boundary. The entity proxy's `get` trap was short-circuiting all symbol-keyed property access to `undefined`, which blocked Signalium's `registerCustomSnapshot` from finding its handler (stored under a private symbol on the prototype). Symbol gets now resolve via `Reflect.get` against the entity prototype. With that in place, the per-class `ensureEntitySnapshotRegistered` bookkeeping is no longer needed — Signalium's prototype-chain resolution makes a single registration on the `Entity` base class apply to all user-defined entity subclasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix entity reactivity across the React boundary. The entity proxy's
gettrap was short-circuiting all symbol-keyed property access toundefined, which blocked Signalium'sregisterCustomSnapshotfrom finding its handler (stored under a private symbol on the prototype). Symbol gets now resolve viaReflect.getagainst the entity prototype. With that in place, the per-classensureEntitySnapshotRegisteredbookkeeping is no longer needed — Signalium's prototype-chain resolution makes a single registration on theEntitybase class apply to all user-defined entity subclasses.