fix(fetchium): Fix CI failures in type checking and tests - #2
Merged
Conversation
- Use relative imports instead of 'src/types.js' absolute paths - Reorder class properties to fix use-before-initialization - Add type assertion for HeadersInit indexing - Add missing variable declarations in skipped tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The test rendered UserComponent with userId="1" but asserted on test-id "user-2". Changed assertion to match "user-1". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jimmy-phantom
changed the title
pzuraq
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot find module 'src/types.js'type check errors by using relative imports in 3 test filesProperty 'params' is used before its initializationby reordering class property declarations in mutations testElement implicitly has an 'any' typeforHeadersInitindexing with a type assertionuser-2should beuser-1)Test plan
npm run check-typespassesnpm run lintpassesnpm run testpasses🤖 Generated with Claude Code