fix(k8s-infra): grant persistentvolumes to otel-agent ClusterRole - #907
Open
haidaraM wants to merge 1 commit into
Open
fix(k8s-infra): grant persistentvolumes to otel-agent ClusterRole#907haidaraM wants to merge 1 commit into
haidaraM wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
persistentvolumesto the otel-agent ClusterRole rules.Why
Since #889 (released in k8s-infra 0.17.0), the kubeletstats receiver is configured with
k8s_api_config: {auth_type: serviceAccount}. With API access configured, the receiver collects detailed PVC labels: it follows each PersistentVolumeClaim to its bound PersistentVolume to resolve the underlying volume type. When that lookup fails, the receiver skips metric collection for the volume entirely.The ClusterRole grants
persistentvolumeclaimsbut notpersistentvolumes, so the PV lookup is forbidden and allk8s.volume.*metrics for PVC-backed volumes are dropped after upgrading to 0.17.0. The otel-agent logs the following for every PVC-backed volume on every scrape:Ref: the receiver's detailed PVC labels setter calls
GetPersistentVolume(kubeletstatsreceiver metadata).