Skip to content

feat(clickhouse): support volumeAttributesClassName on PVC template #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lotooo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(clickhouse): support volumeAttributesClassName on PVC template #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/clickhouse/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: clickhouse
description: A Helm chart for ClickHouse
type: application
version: 24.1.18
version: 24.1.19
appVersion: "24.1.2"
icon: https://github.com/ClickHouse/clickhouse-docs/raw/84f38d893eb7e561c7296279d7953b6a508ec413/static/img/clickhouse-logo.svg
sources:
Expand Down
6 changes: 6 additions & 0 deletions charts/clickhouse/templates/clickhouse-instance/clickhouse-instance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,9 @@ spec:
storageClassName: {{ $storageClass }}
{{- end }}
{{- end }}
{{- if .Values.persistence.volumeAttributesClassName }}
volumeAttributesClassName: {{ .Values.persistence.volumeAttributesClassName }}
{{- end }}
{{- end }}

{{- if and (.Values.templates.volumeClaimTemplates) (not .Values.persistence.enabled) }}
Expand All @@ -404,5 +407,8 @@ spec:
requests:
storage: {{ .resources.requests.storage }}
storageClassName: {{ .storageClassName }}
{{- if .volumeAttributesClassName }}
volumeAttributesClassName: {{ .volumeAttributesClassName }}
{{- end }}
{{- end }}
{{- end }}
7 changes: 7 additions & 0 deletions charts/clickhouse/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ persistence:
#
storageClass: null

# -- VolumeAttributesClass to apply to the data PVC (Kubernetes 1.31+).
# When set, renders `volumeAttributesClassName: <name>` on the PVC, allowing
# in-place modification of volume parameters (e.g. EBS gp3 IOPS/throughput)
# without recreating the underlying volume.
#
volumeAttributesClassName: null

# -- Access Modes for persistent volume
accessModes:
- ReadWriteOnce
Expand Down