Skip to content

feat(otel): allow envFrom in otel collector deployment configuration. - #839

Open
thober35 wants to merge 1 commit into
SigNoz:mainfrom
thober35:feat/allow-envfrom
Open

feat(otel): allow envFrom in otel collector deployment configuration.#839
thober35 wants to merge 1 commit into
SigNoz:mainfrom
thober35:feat/allow-envfrom

Conversation

@thober35

@thober35 thober35 commented Mar 11, 2026

Copy link
Copy Markdown
  • Allow Users to define existing secrets or configmaps for their otelCollector via envFrom

Summary by CodeRabbit

  • New Features
    • Added optional configuration to inject additional environment variables from ConfigMaps or Secrets into the OpenTelemetry Collector component. Users can now specify custom environment sources via Helm values configuration.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5af7ca8-32e8-4c86-bbe2-47c2a7c9c4fb

📥 Commits

Reviewing files that changed from the base of the PR and between 4dc2148 and 72a7f7e.

📒 Files selected for processing (2)
  • charts/signoz/templates/otel-collector/deployment.yaml
  • charts/signoz/values.yaml

📝 Walkthrough

Walkthrough

The changes add support for injecting additional environment sources into the otel-collector container via a new additionalEnvFrom configuration field in the Helm chart values, with corresponding template logic to apply these settings conditionally.

Changes

Cohort / File(s) Summary
Helm Configuration Addition
charts/signoz/templates/otel-collector/deployment.yaml, charts/signoz/values.yaml
Introduces optional otelCollector.additionalEnvFrom field allowing users to specify additional environment variable sources (e.g., ConfigMaps, Secrets) for the otel-collector container. Template conditionally renders the envFrom block when configured.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A carrot-cutter's delight, we say,
New configs bloom in the envFrom way,
Where Secrets and Maps dance in harmony bright,
Our collector now gathers them all, day and night! 🌱✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(otel): allow envFrom in otel collector deployment configuration' directly and clearly describes the main change: adding envFrom support to the otel collector configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thober35
thober35 marked this pull request as ready for review March 11, 2026 07:16
@thober35
thober35 requested a review from a team as a code owner March 11, 2026 07:16
@thober35
thober35 force-pushed the feat/allow-envfrom branch from 72a7f7e to cd1b7ae Compare June 12, 2026 06:13
@thober35

Copy link
Copy Markdown
Author

Hello! Is somebody able to review this PR? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant