feat(settings)!: Add settings.keep_nvim_dir (:h carbon-setting-keep-nvim-dir) - #155
Merged
Conversation
…-nvim-dir) This supports Neovim's new `dir` plugin which shows a directory listing on `:edit [dirname]`. Fixes a double initialization issue on startup where Carbon would be initialized once at the end of the `setup` function and once again via the `FileType` (`BufWinEnter` prior to this commit) autocommand when `settings.open_on_dir` was enabled. The impact of the above wasn't noticable due to Carbon caching entries and lines to render during the first initialization however it is a little bit less smelly now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports Neovim's new
dirplugin which shows a directory listingon
:edit [dirname].Fixes a double initialization issue on startup where Carbon would
be initialized once at the end of the
setupfunction and once againvia the
FileType(BufWinEnterprior to this commit) autocommandwhen
settings.open_on_dirwas enabled.The impact of the above wasn't noticable due to Carbon caching entries
and lines to render during the first initialization however it is
a little bit less smelly now.