Clarify doppler --fallback semantics in entrypoint comment#142
Merged
Conversation
Addresses PR #141 review comment: the fallback file is auto-created by doppler run on each successful fetch and need not pre-exist. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the entrypoint.sh documentation to precisely describe how doppler run --fallback <path> behaves at runtime (auto-creating/refreshing the encrypted fallback file on successful fetches, and only reading it when the API is unreachable).
Changes:
- Clarified
--fallbacksemantics in theentrypoint.shcomment to reflect observed Doppler CLI behavior. - Expanded the comment to note the fallback file does not need to pre-exist and is refreshed on successful secret fetches.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #141, addressing the Copilot review comment on
entrypoint.sh: verified with doppler CLI v3.76.0 thatdoppler run --fallback <path>auto-creates/refreshes the encrypted fallback file on each successful fetch — it need not pre-exist and is only read when api.doppler.com is unreachable. Comment-only change.🤖 Generated with Claude Code