Fix multiproof test#419
Merged
Merged
Conversation
n8mgr
requested review from
ChrisSchinnerl,
chris124567,
Copilot,
lukechampine and
peterjan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing multiproof roundtrip test by aligning the expected empty-slice representation with the decoder’s behavior, and adjusts slice decoding to overwrite (rather than append to) the destination slice.
Changes:
- Update
TestMultiproofEncodingto normalizeTransactionstonilwhen the transaction set is empty, matching decode results. - Change
DecodeSlice/DecodeSliceFnto build decoded elements into a new slice and assign it back, preventing accidental append-to-existing behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
types/multiproof_test.go |
Normalizes empty transaction slices to nil for stable roundtrip equality. |
types/encoding.go |
Updates slice decoding to replace the destination slice instead of appending to it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisSchinnerl
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.