Repository navigation
Stabilize CI E2E by running against production server - #2
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
Co-authored-by: ShubhJain09 <323014600+ShubhJain09@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The route-type reference can break clean CI typechecking, and signup coverage needs boundary cases and deterministic NEXTAUTH_URL.
Review effort: Lite
Findings: None
What changed in this PR
Stabilizes CI E2E by running the built production server and adds controlled CI signup verification coverage.
Changes:
- Runs E2E against
npm run start. - Centralizes local verification gating.
- Adds signup regression coverage and shared Prisma migration setup.
| File | Summary |
|---|---|
echo/tests/integration/fixtures/apply-prisma-migrations.ts |
Shared SQLite migration setup. |
echo/tests/integration/fixtures/account-signup-ci-check.ts |
Isolated signup route fixture. |
echo/tests/integration/accounts.test.ts |
Uses shared database initialization. |
echo/tests/integration/account-signup-ci.test.ts |
Tests CI production-mode signup. |
echo/next-env.d.ts |
References production route types. |
echo/lib/auth/accounts.ts |
Adds local verification gating. |
echo/echo.db |
SQLite database artifact. |
echo/app/api/account/[action]/route.ts |
Applies verification gating to signup. |
.github/workflows/ci.yml |
Runs E2E against the production server. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The failing Actions job was in the Playwright signup flow. CI was exercising E2E against
next dev, which introduced cold-start/HMR instability and broke the expected signup → verify path.CI runtime
npm run startinstead ofnext dev.Signup verification behavior in CI
localVerificationEnabled()for the local-mail verification path.ECHO_LOCAL_MAIL=trueCI=trueRegression coverage
Test DB bootstrap