[polaris.shopify.com] Fix editPageLinkPath to include leading slash for correct URL generation - #13982
Open
SMAKSS wants to merge 2 commits into
Open
[polaris.shopify.com] Fix editPageLinkPath to include leading slash for correct URL generation#13982SMAKSS wants to merge 2 commits into
editPageLinkPath to include leading slash for correct URL generation#13982SMAKSS wants to merge 2 commits into
Conversation
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Open it as a draft if it’s a work in progress --> ### WHY are these changes introduced? 1. [PageActions](https://polaris-react.shopify.com/components/actions/page-actions) are a legacy UX solution. Page actions should instead be presented via the [contextual save bar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar) (in the case of Save) OR via the [Polaris Page](https://polaris-react.shopify.com/components/layout-and-structure/page) action props (i.e. `primaryAction`, `secondaryActions`, `actionGroups`). 2. [FullscreenBar](https://polaris-react.shopify.com/components/navigation/fullscreen-bar) is a legacy UX solution. Instead [max variant modals](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-modal) should be used in combination with the [SaveBar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar) and [TitleBar](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-title-bar). The [App Design Guidelines](https://shopify.dev/docs/apps/design/app-structure) explicitly state not to use FullscreenBar. <img width="840" height="324" alt="01-40-tyci1-sxt9y" src="https://github.com/user-attachments/assets/66ad93f8-9c08-44bc-8eba-03888ff834f6" /> Built for Shopify requirement [4.1.6](https://shopify.dev/docs/apps/launch/built-for-shopify/requirements#use-modals-appropriately), lists using FullscreenBar as a failure example. <img width="910" height="824" alt="01-43-t7px5-mzkqr" src="https://github.com/user-attachments/assets/503c87b1-910b-4003-a821-4b67b20a597d" /> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR moves both the `PageActions` and `FullscreenBar` components to the Deprecated section in the nav. It also displays a "Deprecated" banner on both of the component pages. <img width="1305" height="875" alt="01-59-c5awl-pclmj" src="https://github.com/user-attachments/assets/c5edc48b-aa77-4e33-ba95-a30c286308d0" /> <img width="1307" height="823" alt="01-58-qmsur-50290" src="https://github.com/user-attachments/assets/539050a1-89f3-4269-bd87-b8292e480bca" /> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Contributor
|
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
|
🔎 View this PR in Shipit Next. ℹ️ Expand to learn how to deploy and handle emergencies using Shipit NextOverviewShipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue. To ship this PR, you can either:
Comment Commands
Commands exclusive to Deploy Before Merge
Documentation
Questions or feedback?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8669 and addresses side effects of #11113
WHAT is this pull request doing?
🎩 checklist
README.mdwith documentation changes