Skip to content

Use single-quote for github actions string#217

Merged
swalkinshaw merged 2 commits into
Shopify:mainfrom
rmosolgo:fix-ci-next
Apr 24, 2026
Merged

Use single-quote for github actions string#217
swalkinshaw merged 2 commits into
Shopify:mainfrom
rmosolgo:fix-ci-next

Conversation

@rmosolgo

Copy link
Copy Markdown
Contributor

Oops -- trying to fix the build after #215 !

@swalkinshaw

Copy link
Copy Markdown
Contributor

My fault too I don't think the workflows were run/approved on the last PR 🙈 running now

@swalkinshaw

Copy link
Copy Markdown
Contributor

All the 1.13 tests break:

/home/runner/work/graphql-batch/graphql-batch/vendor/bundle/ruby/3.4.0/gems/graphql-1.13.25/lib/graphql/schema/field.rb:218:in 'initialize': unknown keyword: :resolve_each (ArgumentError)
	from /home/runner/work/graphql-batch/graphql-batch/vendor/bundle/ruby/3.4.0/gems/graphql-1.13.25/lib/graphql/schema/member/accepts_definition.rb:154:in 'GraphQL::Schema::Member::AcceptsDefinition::InitializeExtension#initialize'
	from /home/runner/work/graphql-batch/graphql-batch/vendor/bundle/ruby/3.4.0/gems/graphql-1.13.25/lib/graphql/schema/field.rb:129:in 'Class#new'

I'd also be okay with bumping the req version if that's necessary. Unless there's a simple fix or way to support it

@rmosolgo

Copy link
Copy Markdown
Contributor Author

I can shim it, just a minute 👀

@rmosolgo

rmosolgo commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Ok, that kinda worked locally -- I found that I had to add this locally too:

--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -1,4 +1,5 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require "ostruct"
 require 'graphql/batch'

But that error was before the one described above, and I see "ostruct" is in the gemspec, so it seems like that shouldn't have been necessary. Anyways I'll add it here if it is necessary.

@rmosolgo

Copy link
Copy Markdown
Contributor Author

😌

@swalkinshaw

Copy link
Copy Markdown
Contributor

🎉 thanks

@swalkinshaw swalkinshaw merged commit ec0c104 into Shopify:main Apr 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants