Use single-quote for github actions string#217
Merged
Conversation
1 task
Contributor
|
My fault too I don't think the workflows were run/approved on the last PR 🙈 running now |
Contributor
|
All the 1.13 tests break: I'd also be okay with bumping the req version if that's necessary. Unless there's a simple fix or way to support it |
Contributor
Author
|
I can shim it, just a minute 👀 |
Contributor
Author
|
Ok, that kinda worked locally -- I found that I had to add this locally too: --- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -1,4 +1,5 @@
$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require "ostruct"
require 'graphql/batch'But that error was before the one described above, and I see |
Contributor
Author
|
😌 |
Contributor
|
🎉 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops -- trying to fix the build after #215 !