refactor(tmdb): support DateKindaMatches rating, convert MatchRatingType to string union - #1422
Draft
Foowy wants to merge 1 commit into
Draft
refactor(tmdb): support DateKindaMatches rating, convert MatchRatingType to string union#1422Foowy wants to merge 1 commit into
Foowy wants to merge 1 commit into
Conversation
…ype to string union MatchRatingType is now a string union instead of an enum, per harshithmohan's review on ShokoAnime/ShokoServer#1389. Adds the DateKindaMatches rating (server-side last-resort nearest-air-date fallback) to the abbreviation/color mapping and the "Approximate" count bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateKindaMatchesmatch rating on the server.MatchRatingTypefrom a TS enum to a string union, per harshithmohan's review comment on that PR.DateKindaMatchesto the abbreviation/color mapping inMatchRating.tsxand the "Approximate" count bucket inTopPanel.tsx.Draft — do not merge until ShokoAnime/ShokoServer#1389 merges upstream.
Test plan
pnpm lint(dprint + oxlint) passespnpm tscheckpassesDateKindaMatchesrating