Handle textual responses when tool_calls is empty - #1351
Open
IloDan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some OpenAI-compatible APIs return
message.tool_callsas an empty listfor final textual responses.
The previous parser only fell back to
message.contentwhen iteratingover
tool_callsraised an exception. Withtool_calls=[], it insteadproduced
model_responses=[]and discarded the valid textual response.Fix
message.tool_callswithmessage.tool_calls or []message.contentwhen no tool calls are presentValidation
Tested with Qwen3-8B through a vLLM OpenAI-compatible endpoint on BFCL v4
memory subsets.
Before the fix, all memory subset scores were 0.
After the fix:
This is close to the 14.62% reported for Qwen3-8B FC on the BFCL leaderboard.