fix: add mp-units to package host dependencies#19
Conversation
CMakeLists.txt does `find_package(mp-units 2.5 CONFIG REQUIRED)` for the
SHiP::SHiPUnits target, so mp-units is needed in the build (host)
environment. It was only listed in the workspace `[dependencies]` (this
repo's own dev env), not in `[package.host-dependencies]`, so building
shipdatamodel as a pixi source dependency fails at CMake configure:
Could not find a package configuration file provided by "mp-units"
(requested version 2.5)
The release recipe (ship-conda-recipes/recipes/shipdatamodel) already
lists mp-units in its host:; mirror it here.
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Building
shipdatamodelas a pixi source dependency (e.g. in aegir'sdevenvironment) fails at CMake configure:CMakeLists.txtdoesfind_package(mp-units 2.5 CONFIG REQUIRED)for theSHiP::SHiPUnitstarget, somp-unitsis a build (host) dependency. But it was only listed in the workspace[dependencies](this repo's own dev env), not in[package.host-dependencies]— which is whatpixi-build-cmakeuses to assemble the host environment. So the source build's host prefix has no mp-units.The release recipe (
ship-conda-recipes/recipes/shipdatamodel) already listsmp-unitsin itshost:; this just mirrors it, per the manifest's own "keep the host dependencies in lockstep with [the release recipe]" note.Fix
Verification
Verified end-to-end locally (pixi 0.68.1, current main, refreshed ship channel): with this change, aegir's dev-source build resolves and completes fully — all three source packages build,
pixi install -e dev, aegir's own build/install, and thesmoketask (pythia8 benchmark + phlex gun_noop) all pass.Context
Third and final fix in the chain exposed by aegir's dev-source-build tripwire (ShipSoft/ship-conda-recipes#106); follows data-model#18 (cxx20 root_base) and ship-conda-recipes#133 (geomodel-core channel refresh).