Skip to content

DEV-833/DEV-834 Print firmware version in factory test report; include-safe version.h #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marknolan merged 2 commits into from
Jul 2, 2026
Merged

DEV-833/DEV-834 Print firmware version in factory test report; include-safe version.h #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1c4668
DEV-833/DEV-834 Print firmware version in factory test report; make v…
marknolan Jul 2, 2026
813f6e0
Committing clang-format changes
github-actions[bot] Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Test/shimmer_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <stdio.h>

#include "log_and_stream_includes.h"
#include "version.h"

factory_test_target_t factoryTestTarget = PRINT_TO_DEBUGGER;
factory_test_t factoryTestToRun;
Expand All @@ -23,6 +24,11 @@ uint32_t ShimFactoryTest_run(void)
ShimFactoryTest_sendReport("//**************************** TEST START "
"************************************//\r\n");

/* Record the firmware version running this test so the captured report
* documents exactly which build was used for testing. FW_VERSION_STRING is
* the compile-time version baked into this binary. Prints on every report. */
ShimFactoryTest_sendReport("Firmware version: " FW_VERSION_STRING "\r\n");

shimmerStatus.testResult = 0;

if (factoryTestToRun == FACTORY_TEST_LED_STATES)
Expand Down
6 changes: 4 additions & 2 deletions scripts/increment_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ typedef struct
uint8_t patch;
} firmware_version_t;

__attribute__((section(".version"), used)) static const firmware_version_t fw_version_struct
= { .major = FW_VERSION_MAJOR, .minor = FW_VERSION_MINOR, .patch = FW_VERSION_PATCH };
/* The definition lives in each firmware's main.c so this header can be included
* by multiple translation units without emitting a duplicate object into the
* .version linker section. */
extern const firmware_version_t fw_version_struct;
Comment thread
marknolan marked this conversation as resolved.

#endif //VERSION_H
EOF
Expand Down