Skip to content

🐛 fix(reviewer): sort finding IDs numerically - #31

Merged
SigureMo merged 2 commits into
codex/review-simplificationfrom
codex/review-finding-sort
Sep 26, 2026
Merged

SigureMo merged 2 commits into
codex/review-simplificationfrom
codex/review-finding-sort

Conversation

@SigureMo

@SigureMo SigureMo commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

The dashboard sorted finding IDs lexically, placing F10 immediately after F1. Use dictsort_natural so IDs appear as F1, F2, …, F10 while preserving findings, statuses and canonical thread links.

Requires gh-slate 0.1.1 or newer, which includes the merged upstream filter. The installed CLI has been upgraded to 0.1.1.

Validation: the current gh-slate CLI validates and renders the bundled profile. The original Relax #370 check covered all 19 finding IDs and their links. After restacking, 278 Python tests, 6 frontend tests, 19 browser tests, formatting, type checks and the production build passed.

This PR is co-authored with @codex (gpt-6 astra xhigh)

@SigureMo
SigureMo added this pull request to stack #23 September 25, 2026 16:38
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from 8f46bf6 to 65d6049 Compare September 26, 2026 02:08
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from 65d6049 to 556876d Compare September 26, 2026 02:13
@SigureMo
SigureMo marked this pull request as ready for review September 26, 2026 02:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T04:46:15.101535Z c0f25a7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec8ab5422a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from ec8ab54 to 5ea3007 Compare September 26, 2026 04:05
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from 5ea3007 to 372e8e4 Compare September 26, 2026 04:17
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch 2 times, most recently from 1eca46e to 6f1f2a2 Compare September 26, 2026 04:35
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from 6f1f2a2 to 2303cd2 Compare September 26, 2026 04:36
SigureMo and others added 2 commits September 26, 2026 12:43
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@SigureMo
SigureMo force-pushed the codex/review-finding-sort branch from 2303cd2 to c0f25a7 Compare September 26, 2026 04:44
@SigureMo
SigureMo merged commit 804544e into main Sep 26, 2026
12 checks passed
@SigureMo
SigureMo deleted the codex/review-finding-sort branch September 26, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant