Upgrade to Bevy 0.18#17
Open
jaydevelopsstuff wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
bevyto the current latest version (0.18) and implements all the necessary migration changes. It also upgradeswgputo27—in line with what Bevy 0.18 now uses.Changes
rust-toolchain.tomlwhich explicitly pins the required Rust toolchain version to nightlybevy_gpu_compute
despawninstead ofdespawn_recursiveand removeDespawnRecursiveExttrait imports (0.15 → 0.16)IntoScheduleConfigstrait instead ofIntoSystemConfigs(0.15 → 0.16)Projection::Orthographic(OrthographicProjection { /* ... */ })instead of justOrthographicProjection { /* ... */ }inspawn_fallback_camera(0.15 → 0.16)WgslCode::from_stringandWgslCode::from_fileas unsafe sinceRenderDevice::create_shader_moduleis now marked as an unsafe function (0.15 → 0.16)WgslCode::from_stringcall withinBevyGpuComputeTask::from_shaderin an unsafe block and added// SAFETY: wgsl_shader_module is compiled and validated. This is sort of an assumption I made so if the maintainer could verify that that safety comment is correct that'd be great.RenderDevice::poll, usewgpu::PollType::wait_indefinitely()instead ofwgpu::Maintain::Wait(wgpu 24 → 25)bevy_gpu_compute/examples
MessageWriterinstead of the removedEventWriter(0.16 → 0.17)Projection::Orthographic(OrthographicProjection { /* ... */ })instead of justOrthographicProjection { /* ... */ }(0.15 → 0.16)