Dacade review - #1
Open
Aishat-Akinyemi wants to merge 4 commits into
Open
Conversation
1. Refactored and renamed createListedToken function to listToken. This way it can be called to relist a bought token. 2. I added a canListToken modifier that performs checks to ensure all requirements are met 3. I also updated the transfer of Ether to use call method. Currently that is the recommended method for making transfers to other accounts on EVM
fix syntax error
1. Refactored and renamed createListedToken function to listToken. This way it can be called to relist a bought token. Also, I made it such that the owner of the token is the actual owner of the token, not the nft-contract-account. 2. Refactored `executeSale` such that when an NFT is purchased, the owner property of that NFT is updated to the buyer address and the seller is updated to a zero-address. This is important for when a buyer decides to relist the NFT. 3. refactored `getMyNFTs` so that no bugs are introduced from the above changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a brief description of the smartcontract’s function in the Readme.md
An NFTMarketplace where users can mint NFTs to be listed for sale, for others to buy. New buyers can relist the NFTs.
Refactored and renamed createListedToken function to listToken. This way it can be called to relist a bought token. Also, I made it such that the owner of the token is the actual owner of the token, not the nft-contract-account.
I added a canListToken modifier that performs checks to ensure all requirements are met
I also updated the transfer of Ether to use call method. Currently that is the recommended method for making transfers to other accounts on EVM
Refactored
executeSalesuch that when an NFT is purchased, the owner property of that NFT is updated to the buyer address and the seller is updated to a zero-address. This is important for when a buyer decides to relist the NFT.Also refactored
getMyNFTsso that no bugs are introduced from the above changes