Skip to content

fix: Correct loss of focus issue in overlay mode #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pastaq merged 2 commits into from
Jul 30, 2026
Merged

fix: Correct loss of focus issue in overlay mode #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b766bb
feat: Add is_pid_running function to replace is_process_running
KyleGospo Jul 30, 2026
f842e8e
fix: Use new is_pid_running function for apps not managed by OpenGame…
KyleGospo Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/systems/launcher/reaper.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ static func get_parent_pid(pid: int) -> int:
static func get_pid_group(pid: int) -> int:
return get_pid_property_int(pid, "NSpgid")

## Returns whether the given PID exists and has not exited yet.
static func is_pid_running(pid: int) -> bool:
var status := get_pid_status(pid)
if status.is_empty():
return false
var state := status.get("State", "") as String
return not state.begins_with("Z") and not state.begins_with("X")

# Returns the PID state the given PID is in
static func get_pid_state(pid: int) -> String:
Expand Down
12 changes: 9 additions & 3 deletions core/systems/launcher/running_app.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ func discover_app_type(all_windows: PackedInt64Array, app_pids: PackedInt64Array
func update_wayland_app(app_pids: PackedInt64Array) -> void:
# Check if the app, or any of its children, are still running
var running := is_running()
if not running:
if running:
self.not_running_count = 0
else:
self.not_running_count += 1

# Update the running app's state
Expand Down Expand Up @@ -252,7 +254,9 @@ func update_xwayland_app(all_windows: PackedInt64Array, app_pids: PackedInt64Arr

# Check if the app, or any of its children, are still running
var running := is_running()
if not running:
if running:
not_running_count = 0
else:
not_running_count += 1

# Update the running app's state
Expand Down Expand Up @@ -381,7 +385,9 @@ func get_all_window_ids(all_windows: PackedInt64Array, app_pids: PackedInt64Arra
## Returns true if the app's PID is running or any decendents with the same
## process group.
func is_running() -> bool:
return OS.is_process_running(pid)
if is_ogui_managed:
return OS.is_process_running(pid)
return Reaper.is_pid_running(pid)


## Return true if the currently running app is focused
Expand Down
Loading