Fix .ani cursor support, preview rendering, and hyprcursor output - #3
Open
Crymfox wants to merge 5 commits into
Open
Fix .ani cursor support, preview rendering, and hyprcursor output#3Crymfox wants to merge 5 commits into
Crymfox wants to merge 5 commits into
Conversation
Crymfox
commented
Jun 16, 2026
Crymfox
commented
- Fix preview not showing for .ani cursors (frame PNGs saved to cache)
- Fix empty cursors/hyprcursors directory in output (prefix matching for file names)
- Fix preview flickering when scrolling between cursors
- Fix cursor size mismatch between xcursor and hyprcursor outputs
- Fix hyprcursor size switching by adding required nominal_size to meta.hl
- Add X11 cursor theme metadata for XWayland compatibility
- Auto-sync runner dirs on cursor folder load for better UX
- Save .ani frame images as PNGs to a temp cache dir so the hotspot editor preview can display them - Auto-sync runner input/output dirs on cursor folder load (no manual "i"/"o" needed) - Add explicit error messages when pipeline starts with missing dirs - Fix cursor loading fallback for .ani dirs (.ok().filter(!empty))
- build_from_xcur_files now does prefix matching (e.g., Normal_32-48-64 matches Normal) instead of requiring exact file names
- Removed StatefulProtocol cache that caused stale rendering state when scrolling between cursors - Protocols are now created fresh each render from cached base images - Added preload_variant to pre-cache base images for smooth animation
- Resize images to match their nominal size in to_x11() so xcursor and hyprcursor outputs have consistent sizing
- Add nominal_size = 1.0 to meta.hl (required by hyprcursor spec) - Remove invalid sizes field from manifest.hl - Add Size=48 to index.theme and [Xcursor] section to cursor.theme for X11 compatibility
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.