Rework AMDS daisy chain implementation - #140
Open
AwesomeTornado wants to merge 8 commits into
Open
Conversation
Removed unused NOP macros and updated comment for wait_cycles calculation.
Contributor
|
Thanks @AwesomeTornado! Is this ready for review + release, or still in draft stage? |
Member
Author
|
@elsevers This is ready for review + release. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139, #803
@elsevers
Notes
This update:
try process routingDuring tests, the FBC board was about 1us faster, while the AMDS was about 4us faster.
I have not yet collected data to prove this, this is based off of what I saw during testing.
DMA seems to be done within interrupts, so I am unsure as to why it still works while they are disabled. Regardless, doing so has made data transmission faster and more consistent.
Testing was done on FBC and AMDS daisy chain setups, with the following screenshot showing @knvprasad-dr's setup working with this new firmware.


Testing was done with three daisy chained AMDS boards, and the AMDC counters showed no bad data.
Self-Review
Approachsection of the issue(s) it is closing? YesReviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist