Skip to content

[Prototype] Concatenated weights and linear layers - #366

Closed
jlamypoirier wants to merge 4 commits into
mainfrom
jlp/concatenated_meta
Closed

[Prototype] Concatenated weights and linear layers#366
jlamypoirier wants to merge 4 commits into
mainfrom
jlp/concatenated_meta

Conversation

@jlamypoirier

@jlamypoirier jlamypoirier commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

✨ Description

Handle concatenated weights, i.e. weights that are stored as one in memory for computation / optimization purpose but actually consist of multiple logically distinct ones. Ex. Key and value, gated MLP layer 1, MoE layers, SSM in_proj, etc.

This lets the engine know about the structure, and allow configuring each sub-parameter independently (lr_scale, initialization, weight decay, peft enabling. Bias enabling split possible but not implemented).

Prototype is working but postponing finalization in favor of higher priority content. Remaining:

  • Simplify linear layer concatenation and make it safer (especially peft)
  • Use for remaining linear layers
  • Make remaining tests pass.

@jlamypoirier

Copy link
Copy Markdown
Contributor Author

Claude Opus 4.8 note: Closing this prototype in favor of #533, which captures the goal and the prototype's mechanism (the ConcatenatedParameterMeta approach) at design level. The branch is ~108 commits behind main and predates the linear/PEFT rework, so it's preserved as a reference rather than a rebase target. Implementation details would be stale by the time this is picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant