fix: remove unused runtime dependency npm (Dependabot #105) - #102
Merged
Conversation
…ce-expansion The npm@11.18.0 runtime dependency bundles brace-expansion@5.0.7 (GHSA-rgw5-rvv9-x895, high severity DoS). npm is never imported in the extension code, so removing it drops the entire vulnerable subtree from package-lock.json and shrinks the published VSIX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alert #105 (GHSA-rgw5-rvv9-x895, high severity DoS).
The runtime dependency
npm@11.18.0bundlesbrace-expansion@5.0.7, which is vulnerable (first patched version 5.0.9).npmis never imported in the extension code, so removing it:Verified:
npm run compile,npm run lint(only pre-existing warnings),npm run esbuildall pass.