fix: remove docker.sock mount from linter container - #44
Merged
Merged
Conversation
- Remove -v /var/run/docker.sock mount from scripts/lint.sh
- Add comment explaining docker.sock is intentionally omitted
- Update BACKLOG.md to mark Item 9 completed
Closes #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Docker socket mount from the linter container. The linter only runs filesystem-level scans (shellcheck, ruff, mypy, hadolint, trivy fs) and does not need Docker access.
Changes
scripts/lint.sh: Removed the-v /var/run/docker.sock:...volume mount and added a comment explaining the design.BACKLOG.md: Marked Item 9 as completed.Security
Removing docker.sock from the linter container eliminates a vector where linting processes could potentially interact with the host Docker daemon. This is defense-in-depth — no vulnerability was actively being exploited.
Closes #43