feat: add brokered WinInspect mutation endpoints (Phase 1) - #116
Merged
Conversation
Three changes:
1. Protocol version (Item 3): Updated from 0.3.0 to 0.4.0 to match
current WinInspect daemon version.
2. window.listChildren (Item 7): Added list_children() method and
GET /wininspect/window/{hwnd}/children endpoint. Enables recursive
UIA tree traversal.
3. Added window.getZOrder to READ_ONLY_METHODS (useful for tab/window
ordering queries).
Adds mutation endpoints behind WineBot's Input Broker: - POST /wininspect/click — window.controlClick or input.mouseClick (uses window_id for controlClick, otherwise mouseClick) - POST /wininspect/key — input.text or input.hotkey (single keys use text, composite keys with + use hotkey) - POST /wininspect/hotkey — input.hotkey All endpoints check broker.check_access() first (423 if denied), then report_agent_activity(). New wininspect.py functions: - control_click(hwnd, x, y, button) - mouse_click(x, y, button) - send_text(text) - send_hotkey(keys) - mutation_request() method set Part of Package C (WineBot Read Expansion).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds WinInspect mutation endpoints behind WineBot's Input Broker. All endpoints check
broker.check_access()(returns 423 if denied) and callbroker.report_agent_activity()on success.Endpoints
Models
Reuses existing
ClickModelandKeyModelfromapi/core/models.py.Part of Package C (WineBot Read Expansion).
Closes #118