feat: track new LA click types via data-feature-name#152
Open
yodem wants to merge 1 commit into
Open
Conversation
Report new assistant_click feature_names via a dedicated data-feature-name
attribute, read by the host click tracker before the generic link/aria-label
logic so anchors report clean labels without degrading accessibility:
- appetizer topics -> related_topics_link (drop stopPropagation so the click
reaches the host tracker; keep preventDefault)
- thinking toggle -> thinking_steps_toggle
- thinking ref link -> thinking_steps_text_link
initial_location_link (pin-in-location / context chip) is deferred: that
element is not present on this base and is wired in one line once it lands.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3 tasks
📊 Code Quality Score: 6/100
Was this score accurate? 👍 Yes · 👎 No Scored by GitVelocity · How are scores calculated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sc-44684 (3 of 4 labels).
New
assistant_clickfeature_names via a dedicateddata-feature-nameattribute, read by the host click tracker before the generic link/aria-label
logic (so anchors report clean labels without degrading accessibility):
related_topics_linkthinking_steps_togglethinking_steps_text_linkinitial_location_link(context chip — not on this base)Validation: needs to be verified in cauldron before deploy (per story).
🤖 Generated with Claude Code