Skip to content

[New Feature] Silent Payment#949

Draft
notTanveer wants to merge 5 commits into
SeedSigner:devfrom
notTanveer:sp-send-support
Draft

[New Feature] Silent Payment#949
notTanveer wants to merge 5 commits into
SeedSigner:devfrom
notTanveer:sp-send-support

Conversation

@notTanveer

@notTanveer notTanveer commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds Silent Payments support to SeedSigner. #569

With these changes, SeedSigner can now sign Silent Payment (sp1) transactions using Sparrow as the coordinator. I've tested the implementation end-to-end, and existing transaction flows (including non-Silent Payment sends) continue to work as expected.

Additional Information

This PR is currently marked as a draft because it depends on the upstream embit changes in PR #145:

Until that PR is merged, we can't move forward with this implementation. I would urge to review the upstream PR as well it will help get this implementation across the finish line. rn, i have tested built it on top of embit fork.

Review Notes

Screenshots


This pull request is categorized as a:

  • New feature

Checklist

I ran pytest locally

  • All tests passed before submitting the PR

I included screenshots of any new or modified screens

Should be part of the PR description above.

  • Yes

I added or updated tests

Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.

  • Yes

I tested this PR hands-on on the following platform(s):

  • Emulator

@notTanveer notTanveer changed the title Sp send support [New Feature] Silent Payment Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant