Update screenshots for v0.8.7 (libraqm/RAQM enabled); add 13 languages#22
Open
kdmukAI-bot wants to merge 1 commit into
Open
Update screenshots for v0.8.7 (libraqm/RAQM enabled); add 13 languages#22kdmukAI-bot wants to merge 1 commit into
kdmukAI-bot wants to merge 1 commit into
Conversation
Regenerated the full screenshot set against seedsigner dev (v0.8.7) with the generator's now-default libraqm/RAQM text layout enabled. The previous set was generated with RAQM explicitly disabled (the old generator patched PIL.ImageFont.core.HAVE_RAQM = False to mimic the pre-libraqm Pi Zero). v0.8.7 enforces libraqm, so every existing screenshot changes at the pixel level from HarfBuzz text shaping, in addition to genuine v0.8.6 -> v0.8.7 content changes (e.g. 'Review PSBT' -> 'Review Transaction', label casing, new/removed views). Also adds screenshots for 13 newly-supported languages: cs, el, fa, hi, id, ko, no, pl, pt_BR, ru, th, tr, vi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the full SeedSigner screenshot set for v0.8.7 with the screenshot generator's now-default libraqm/RAQM text rendering enabled, and adds screenshots for 13 newly-supported languages.
Why nearly every existing screenshot changes
The prior screenshots were generated with RAQM explicitly disabled — the older generator patched
PIL.ImageFont.core.HAVE_RAQM = Falseto mimic the pre-libraqm Pi Zero output. That workaround was removed (#774) and the generator now requires libraqm. Switching from PIL's BASIC layout to HarfBuzz/RAQM shaping shifts glyph positioning and anti-aliasing on essentially every text-bearing screen, so the diff is large by nature — even where the on-screen content is unchanged.On top of the rendering change, there are genuine v0.8.6 → v0.8.7 content changes (e.g. "Review PSBT" → "Review Transaction", button label casing, new and removed views).
Changes
ca,de,en,es,fr,it,ja,nl,zh_Hans_CNcs,el,fa,hi,id,ko,no,pl,pt_BR,ru,th,tr,viGenerated from seedsigner
dev(v0.8.7) viapytest tests/screenshot_generator/generator.pywith libraqm installed.