fix: allow codec field to be optional

[Secon-ary]

Hi, thank you for the works. The extension is working great, but I encounter missing codec field error in some of my library. I tried to check said library using ffmpeg, turn out it did miss some audio codec. Though the movie and its audio is working fine.

So, this change is just to make codec filed to be optional. Take a note that I don't fully understand how Jellyfin nor video component work. So, I don't know whether this change will break other code or not. Please forgive my English, it's not my first language. Thanks!

Checklist:

• Updated extVersionCode value in build.gradle for individual extensions
• Referenced all related issues in the PR body (e.g. "Closes #xyz")
• Added the isNsfw = true flag in build.gradle when appropriate
• Have not changed source names
• Have explicitly kept the id if a source's name or language were changed
• Have tested the modifications by compiling and running the extension through Android Studio
• Have removed web_hi_res_512.png when adding a new extension

[Secozzi]

The codec is only used in external subtitles, but since the codec for the subtitles is required, could you add a null check there?

Also, you need to bump extVersionCode in the build.gradle file

[Secon-ary]

I have added null check and bump version code

[Secon-ary]

As in, if codec is null, we skip subtitles entirely?

[Secon-ary]

Sorry, I just realize after committing your suggestion. Your suggestion is like this

                    if (media.supportsExternalStream) {
                        val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                            addPathSegment("Videos")
                            addPathSegment(itemId)
                            addPathSegment(mediaSource.id!!)
                            addPathSegment("Subtitles")
                            addPathSegment(media.index.toString())
                            addPathSegment("0")
                            if (media.codec != null) {
                                addPathSegment("Stream.${media.codec}")
                        if (media.supportsExternalStream && media.codec != null) {
                            val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                            addPathSegment("Videos")
                            addPathSegment(itemId)
                            addPathSegment(mediaSource.id!!)
                            addPathSegment("Subtitles")
                            addPathSegment(media.index.toString())
                            addPathSegment("0")
                            addPathSegment("Stream.${media.codec}")
                        }.build().toString()

Did you mean like this:

                   if (media.supportsExternalStream && media.codec != null) {
                       val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                           addPathSegment("Videos")
                           addPathSegment(itemId)
                           addPathSegment(mediaSource.id!!)
                           addPathSegment("Subtitles")
                           addPathSegment(media.index.toString())
                           addPathSegment("0")
                           addPathSegment("Stream.${media.codec}")
                       }.build().toString()

[Secon-ary]

I just go ahead and use this version:

                   if (media.supportsExternalStream && media.codec != null) {
                       val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                           addPathSegment("Videos")
                           addPathSegment(itemId)
                           addPathSegment(mediaSource.id!!)
                           addPathSegment("Subtitles")
                           addPathSegment(media.index.toString())
                           addPathSegment("0")
                           addPathSegment("Stream.${media.codec}")
                       }.build().toString()

Let me know if that's not you wanted. I will revert it later.
Sorry, I haven't use Kotlin or done any mobile development in a long time.

[Secozzi]

Sorry, I just realize after committing your suggestion. Your suggestion is like this

                    if (media.supportsExternalStream) {
                        val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                            addPathSegment("Videos")
                            addPathSegment(itemId)
                            addPathSegment(mediaSource.id!!)
                            addPathSegment("Subtitles")
                            addPathSegment(media.index.toString())
                            addPathSegment("0")
                            if (media.codec != null) {
                                addPathSegment("Stream.${media.codec}")
                        if (media.supportsExternalStream && media.codec != null) {
                            val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                            addPathSegment("Videos")
                            addPathSegment(itemId)
                            addPathSegment(mediaSource.id!!)
                            addPathSegment("Subtitles")
                            addPathSegment(media.index.toString())
                            addPathSegment("0")
                            addPathSegment("Stream.${media.codec}")
                        }.build().toString()

Did you mean like this:

                   if (media.supportsExternalStream && media.codec != null) {
                       val subtitleUrl = baseUrl.toHttpUrl().newBuilder().apply {
                           addPathSegment("Videos")
                           addPathSegment(itemId)
                           addPathSegment(mediaSource.id!!)
                           addPathSegment("Subtitles")
                           addPathSegment(media.index.toString())
                           addPathSegment("0")
                           addPathSegment("Stream.${media.codec}")
                       }.build().toString()

Ah yes, that's what i thought i suggested but it seems like Github messed it up

[Secon-ary]

Great, thank you