borrowck: detect FnMut for CoroutineClosure in region error helpers#608
Open
SebTardif wants to merge 1 commit into
Open
borrowck: detect FnMut for CoroutineClosure in region error helpers#608SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
`is_closure_fn_mut` only considered `DefiningTy::Closure`, so region diagnostics for async/coroutine closures never treated `ClosureEnv` as `FnMut` even when the coroutine-closure kind was `FnMut`. Include `DefiningTy::CoroutineClosure` via `as_coroutine_closure().kind()`. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606
Summary
is_closure_fn_mutnow recognizesDefiningTy::CoroutineClosureand checksas_coroutine_closure().kind() == FnMut, so region diagnostics that branch on this helper behave correctly for async/coroutine closures.Origin
Compiler audit (CoroutineClosure region diagnostic gaps), SebTardif/rust.
Test plan
FnMutkind should report asFnMutviais_closure_fn_mut.