std: reject interior NULs in UEFI process::Command argument encoding#603
Open
SebTardif wants to merge 1 commit into
Open
std: reject interior NULs in UEFI process::Command argument encoding#603SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
create_args copied program and arg OsStrs into a wide LoadOptions buffer without rejecting embedded 0 units. UEFI treats these as C-style wide strings (see os_string_to_raw / OwnedDevicePath::from_text), so an interior NUL would truncate the command line. Return InvalidInput early. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #601
Summary
create_argsnow rejects program/argOsStrs containing interior wide0(same policy asos_string_to_raw/OwnedDevicePath::from_text) and returnsio::Result.output()propagates the error beforeset_args.Origin
External-input audit (UEFI process spawn / C-style wide strings), SebTardif/rust.
Test plan
helpers.rs.0unchanged.