std: reject interior NULs in Windows env::set_current_dir / chdir#600
Open
SebTardif wants to merge 1 commit into
Open
std: reject interior NULs in Windows env::set_current_dir / chdir#600SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
chdir built the wide path with encode_wide plus a trailing 0 only, so an interior NUL truncated SetCurrentDirectoryW. Route through to_u16s which rejects NULs and appends the terminator. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597
Summary
Route Windows
chdirthroughto_u16sso interior NULs are rejected beforeSetCurrentDirectoryW, consistent with other WinAPI path helpers.Origin
External-input audit (Windows path / WinAPI string truncation), SebTardif/rust.
Test plan
to_u16s).InvalidInputinstead of truncating cwd.