std: reject interior NULs in Windows Command program name (argv0)#598
Open
SebTardif wants to merge 1 commit into
Open
std: reject interior NULs in Windows Command program name (argv0)#598SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
make_command_line copied argv0 via encode_wide without ensure_no_nuls. An embedded wide NUL would truncate the CreateProcessW command line while args already go through append_arg which checks for NULs. Align argv0 with make_envp / make_dirp. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595
Summary
Call
ensure_no_nuls(argv0)?inmake_command_linebefore encoding the program name into the wideCreateProcessWcommand line. Arguments already go throughappend_arg(NUL-checked); env and cwd helpers in the same module useensure_no_nuls. This closes the argv0 gap.Origin
External-input audit (Windows process spawn / WinAPI string truncation), SebTardif/rust.
Test plan
make_command_lineunit tests unchanged for normal paths.OsStringcontaining interior0should returnInvalidInput(cannot run on this host; Windows-only).